-
Notifications
You must be signed in to change notification settings - Fork 1
[BUILD FAIL] [FEATURE] 유저 회원가입 추가 #302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 기존 쿠키 방식에서 수정됨으로 해당 로직의 변경이 필요함, 협의 필요.
- 명명 일관성 유지
- 당장 삭제하면 문제 발생할 것 같아서 우선 구현 후 삭제 예정.
- 유저로 책임이 넘어갔음.
- new suffix 는 삭제 예정 - 봉사자와 기관에 겹치는 속성인 연락처는 공통 속성에 추가.
- 저장 기능 추가
- center repository 구현체 수정
1 task
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
빌드에 실패했습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



resolved :
📌 과제 설명
회원가입을 만들기 위해서 기존 로직들을 적절히 리팩토링한 후, 작업을 시작했습니다.
기존 봉사자와 기존 기관의 로직에서 문제가 생기지 않도록 새로운 봉사자와 기관을 구현했습니다.
이를 기준으로 각자 맡으신 도메인의 수정을 부탁드리겠습니다!
👩💻 요구 사항과 구현 내용
✅ PR 포인트 & 궁금한 점
rollback 커밋들은 기존 봉사자와 기관의 로직을 삭제하던 중, 이를 취소했던 커밋입니다. 너무 일이 커지는 것 같아서 되돌리고 새로운 봉사자와 기관을 구현하는 것으로 방향을 변경했습니다.